feat: add semantic tokens #2191
Draft
+114
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to angular/angular#60260 |
JannikLassahn
force-pushed
the
feature/semantic-tokens
branch
from
1819d82 to
1a2f94b
Compare
atscott
reviewed
Jun 20, 2025
| import * as ts from 'typescript/lib/tsserverlibrary'; | ||
| import * as lsp from 'vscode-languageserver/node'; | ||
|
|
||
| export enum TokenEncodingConsts { |
There was a problem hiding this comment.
Would you mind linking to the TS definitions like you did in angular/angular#60260? Context is pretty lost between the two sometimes
atscott
reviewed
Jun 20, 2025
Comment on lines
+53
to
+62
| function getTokenTypeFromClassification(tsClassification: number): number|undefined { | ||
| if (tsClassification > TokenEncodingConsts.modifierMask) { | ||
| return (tsClassification >> TokenEncodingConsts.typeOffset) - 1; | ||
| } | ||
| return undefined; | ||
| } | ||
|
|
||
| function getTokenModifierFromClassification(tsClassification: number) { | ||
| return tsClassification & TokenEncodingConsts.modifierMask; | ||
| } |
There was a problem hiding this comment.
Hmm, I wonder if this should really be something that the language service provides since it's so highly dependent on the offset and modifier mask actually matching what the language service returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration for semantic tokens provided by @angular/language-service.
Only supports token type 'class' at the moment.